Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to read Maven version and Git hash #335

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Apr 1, 2024

Also show the version in the autograding log.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Apr 1, 2024
}

protected String readGitProperty(final String key, final FilteredLog log) {
try (var propertiesFile = getClass().getResourceAsStream("/git.properties")) {

Check warning

Code scanning / CodeQL

Unsafe use of getResource Warning

The idiom getClass().getResource() is unsafe for classes that may be extended.
Copy link

github-actions bot commented Apr 1, 2024

☀️ Quality Monitor

  • 🚦 Tests: 108 tests passed
  • 👣 Code Coverage: 76% coverage achieved
  • 🔬 Mutation Coverage: 74% mutations killed
  • ⚠️ Style: 4 warnings found (0 error, 1 high, 2 normal, 1 low)
  • 🐛 Bugs: 3 warnings found (0 error, 0 high, 0 normal, 3 low)

More details are available in the GitHub Checks Result.

@uhafner uhafner merged commit 5ff90da into main Apr 1, 2024
15 checks passed
@uhafner uhafner deleted the version-info branch April 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant