Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown details as additional parameter to create source code annotations #331

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

uhafner
Copy link
Owner

@uhafner uhafner commented Mar 23, 2024

For analysis issues, these details will be filled with the documentation of the corresponding static analysis tool.

Required for uhafner/autograding-gitlab-action#27

For analysis issues, these details will be filled with
the documentation of the corresponding static analysis tool.

See uhafner/autograding-gitlab-action#27
@uhafner uhafner added the enhancement Enhancement of existing functionality label Mar 23, 2024
*/
@SuppressWarnings("checkstyle:ParameterNumber")
protected abstract void createComment(CommentType commentType, String relativePath,
int lineStart, int lineEnd,
String message, String title,
int columnStart, int columnEnd,
String details);
String details, String markDownDetails);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'details' is never used.
*/
@SuppressWarnings("checkstyle:ParameterNumber")
protected abstract void createComment(CommentType commentType, String relativePath,
int lineStart, int lineEnd,
String message, String title,
int columnStart, int columnEnd,
String details);
String details, String markDownDetails);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'markDownDetails' is never used.
Copy link

☀️ Quality Monitor

  • 🚦 Tests: 108 tests passed
  • 👣 Code Coverage: 78% coverage achieved
  • 🔬 Mutation Coverage: 74% mutations killed
  • ⚠️ Style: 4 warnings found (0 error, 1 high, 2 normal, 1 low)
  • 🐛 Bugs: 2 warnings found (0 error, 0 high, 0 normal, 2 low)

More details are available in the GitHub Checks Result.

@uhafner uhafner merged commit f8ef0a6 into main Mar 23, 2024
15 checks passed
@uhafner uhafner deleted the markdown-description branch March 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant