Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NEMS and CMEPS, add CDEPS tests, fix bugs in the datm_bulk_gefs test #538

Merged
merged 25 commits into from
May 5, 2021

Conversation

binli2337
Copy link
Collaborator

@binli2337 binli2337 commented Apr 22, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  1. Update NEMS component for CDEPS data atmosphere model.
  2. Update CMEPS to revise land-sea masks used for cfsr and gefs data sources in CDEPS.
  3. Update CMakeLists.txt to build the mom6_cice6_cdeps application.
  4. Use a new ESMF configuration file for CDEPS model instead of the XML configuration file.
  5. Use new input forcing files that are CF-1.0 compliant in time axis.
  6. Use new input mesh files that are generated from existing grid files.
  7. Add 8 cdeps regression tests.
  8. Fix bugs in the datm_bulk_gefs test.

Issue(s) addressed

fixes: NOAA-EMC/NEMS#99
fixes: NOAA-EMC/CMEPS#42
fixes: #456

Related pull requests

NOAA-EMC/NEMS#92
NOAA-EMC/CMEPS#43

Testing

Regression tests will be done on Hera, Orion, WCOSS-p3, WCOSS-Cray, Gaea, Jet and Cheyenne.

@github-actions
Copy link

@binli2337 please bring these up to date with respective authoritative repositories

  • cdeps NOT up to date

@github-actions
Copy link

@binli2337 please bring these up to date with respective authoritative repositories

  • cdeps NOT up to date

@binli2337 binli2337 added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label May 4, 2021
@BrianCurtis-NOAA
Copy link
Collaborator

Looks like Dom snuck in the rt.sh fix I mentioned in the meeting earlier last week. I will test with the Cheyenne gnu label to make sure we're good.

@BrianCurtis-NOAA
Copy link
Collaborator

OK Thanks. Things are looking good so far!

@binli2337
Copy link
Collaborator Author

@BrianCurtis-NOAA WCOSS-Cray tests are running too. Thanks.

@BrianCurtis-NOAA
Copy link
Collaborator

Just checked on the Orion job, it's stuck Pending on the 123 node task.

@DeniseWorthen
Copy link
Collaborator

is that the only test that is still pending?

@BrianCurtis-NOAA
Copy link
Collaborator

is that the only test that is still pending?

Yes

@DusanJovic-NOAA
Copy link
Collaborator

Requesting 123 nodes (4920 cpus) is a little too much for a (regression) test. I think.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented May 5, 2021 via email

@BrianCurtis-NOAA
Copy link
Collaborator

Machine: orion
Compiler: intel
Job: BL
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/621044763/20210504153013/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_281281
Test fv3_wrtGauss_nemsio_c768 101 failed in run_test failed
Please make changes and add the following label back:
orion-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator

Noting that we've decided to skip the fv3_wrtGauss_nemsio_c768 for now on Orion on purpose.

@binli2337 binli2337 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label May 5, 2021
@DeniseWorthen
Copy link
Collaborator

both nems and cmeps have been merged so please revert your gitmodules and update. Thanks.

@MinsukJi-NOAA
Copy link
Contributor

both nems and cmeps have been merged so please revert your gitmodules and update. Thanks.

@binli2337 please specify run-ci in the commit message of your latest commit before the push to the Github

@binli2337 binli2337 merged commit d7156ad into ufs-community:develop May 5, 2021
@binli2337 binli2337 deleted the feature/new_cdeps7 branch May 30, 2021 20:20
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Add write_dopost for inline post

* Add inline_post to run_fcst script

* Turn off run_post when true

* Add postprod to run_fcst script

* Update workflow template for inline post

* Add a WE2E test for inline post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
6 participants