Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically checking if repos are up to date #547

Closed
MinsukJi-NOAA opened this issue Apr 28, 2021 · 3 comments
Closed

Automatically checking if repos are up to date #547

MinsukJi-NOAA opened this issue Apr 28, 2021 · 3 comments
Assignees
@MinsukJi-NOAA
Labels
bug Something isn't working

Comments

@MinsukJi-NOAA
Copy link
Contributor

Description

Automatically checking if the repos of a PR are up to date does not work properly when a submodule itself is being updated.

To Reproduce:

Here (#538), the notification by github-actions bot is incorrect.
@binli2337 is updating CDPES repo, and therefore it should recognize his branch is up to date.
@MinsukJi-NOAA MinsukJi-NOAA added the bug Something isn't working label Apr 28, 2021
@MinsukJi-NOAA MinsukJi-NOAA self-assigned this Apr 28, 2021
@MinsukJi-NOAA MinsukJi-NOAA mentioned this issue Apr 28, 2021
Merged
13 tasks
@JessicaMeixner-NOAA
Copy link
Collaborator

@MinsukJi-NOAA I just ran into this issue too, but have a question. For WW3 in general, we allow commits to WW3 before a commit to ufs-weather-model updating it to it's latest version is made. Sometimes this is fine, but other times this might require other changes that the WW3 code managers (@aliabdolali & me as back-up) need to submit a PR for to ufs-weather-model. So if someone is updating WW3, then it should be the latest, but if their PR is not related to WW3 it should be the same as what it is in ufs-weather-model, not necessarily the top of the WW3 develop branch. Does this account for that? I can explain more if that doesn't make sense.

@MinsukJi-NOAA MinsukJi-NOAA mentioned this issue Apr 29, 2021
Merged
13 tasks
@MinsukJi-NOAA
Copy link
Contributor Author

@JessicaMeixner-NOAA thanks for reporting this issue. I modified the code to compare with the submodule version pointed to by the ufs-weather-model instead of the top of develop of the submodule. A comment was also left in your PR conversation.

@MinsukJi-NOAA
Copy link
Contributor Author

Changes were merged via #527.

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@JiliDong-NOAA
change input.nml for filter topo to fix task failure (#547)
8b53fa9 
## DESCRIPTION OF CHANGES: 
Remove "refine_ratio = ${refine_ratio}" in scripts/exregional_make_orog.sh to fix filter_topo failure

## TESTS CONDUCTED: 

regional ESG grids/topography

## DEPENDENCIES:


## DOCUMENTATION:


## ISSUE (optional): 
Fixes issue mentioned in #546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MinsukJi-NOAA MinsukJi-NOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JessicaMeixner-NOAA @MinsukJi-NOAA