-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[production/AQM.v7] To improve AQMv7 package to meet NCO implementation stardards #983
Merged
chan-hoo
merged 24 commits into
ufs-community:production/AQM.v7
from
JianpingHuang-NOAA:feature/AQMv7_release_v7
Dec 1, 2023
Merged
[production/AQM.v7] To improve AQMv7 package to meet NCO implementation stardards #983
chan-hoo
merged 24 commits into
ufs-community:production/AQM.v7
from
JianpingHuang-NOAA:feature/AQMv7_release_v7
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleated ufs files
…les in restart files
JianpingHuang-NOAA
requested review from
chan-hoo,
RatkoVasic-NOAA and
BenjaminBlake-NOAA
as code owners
December 1, 2023 16:57
chan-hoo
changed the title
To improve AQMv7 package to meet NCO implementation stardards
[production/AQM.v7] To improve AQMv7 package to meet NCO implementation stardards
Dec 1, 2023
@JianpingHuang-NOAA, this PR has a conflict. Please resolve it. |
@chan-hoo I have changed the Externals.cfg to be consistent with yours. Let me know if you still meet a conflict. |
@JianpingHuang-NOAA, I can see the same conflict message. |
chan-hoo
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used to address the EE2 issues in support AQMv7 implementation. The issues are more than the following three below
Please be reminded this package has been fully tested with ecflow only.
Type of change
TESTS CONDUCTED:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
Jianping Huang and Lin Gan