Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/AQM.v7] To improve AQMv7 package to meet NCO implementation stardards #983

Conversation

JianpingHuang-NOAA
Copy link

@JianpingHuang-NOAA JianpingHuang-NOAA commented Dec 1, 2023

This PR is used to address the EE2 issues in support AQMv7 implementation. The issues are more than the following three below

  1. 970 with ufs-srw-app (Link)
  2. 971 with ufs-srw-app (Link)
  3. 972 with ufs-srw-app (Link)

Please be reminded this package has been fully tested with ecflow only.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

Jianping Huang and Lin Gan

@chan-hoo chan-hoo changed the title To improve AQMv7 package to meet NCO implementation stardards [production/AQM.v7] To improve AQMv7 package to meet NCO implementation stardards Dec 1, 2023
@chan-hoo
Copy link
Collaborator

chan-hoo commented Dec 1, 2023

@JianpingHuang-NOAA, this PR has a conflict. Please resolve it.

@JianpingHuang-NOAA
Copy link
Author

@chan-hoo I have changed the Externals.cfg to be consistent with yours. Let me know if you still meet a conflict.

@chan-hoo
Copy link
Collaborator

chan-hoo commented Dec 1, 2023

@JianpingHuang-NOAA, I can see the same conflict message.

@chan-hoo chan-hoo merged commit 73074e1 into ufs-community:production/AQM.v7 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants