-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[production/AQM.v7] Ex-scripts can not call any python scripts from ~/sorc #982
Comments
@JianpingHuang-NOAA, you can add a copy command right before the above command line like:
Isn't this allowed either? |
@chan-hoo Let me bring Carlos to answer your questions @CarlosMDiaz-NCO |
@chan-hoo @JianpingHuang-NOAA Would we also need to copy the ${ARL_NEXUS_DIR}/config to the parm location as well? |
Files in sorc/ should not be referenced at all during run-time. The needed files can be copied into ush/, parm/, fix/, etc. as part of the build script and then the variables (e.g. PARMaqm_utils, ARL_NEXUS_DIR) updated. What I've found so far that will need to be updated, either to scripts copied to ush/ or to config files copied to parm/ or fix/
|
@CarlosMDiaz-NCO, Thanks for the clarification. I'll add the copy commands for them to the build script |
@chan-hoo Can I open a PR to merge my branch into production/AQM.v7? We have made a lot of changes to address EE2 compliance. Is it ok for you to merge my PR before you make further changes? |
@JianpingHuang-NOAA, yes, please open it ASAP. |
@JianpingHuang-NOAA, your PR has a conflict. Once you resolve it, I'll merge it. |
@chan-hoo Where is the conflict message? |
On the bottom |
NCO SPA team noticed that exaqm_nexus_post_split.sh and exaqm_nexus_emission.sh call python script from ~/sorc.
Here is an example.
python3 ${ARL_NEXUS_DIR}/utils/python/nexus_nei2016_linker.py --src_dir ${NEXUS_INPUT_BASE_DIR} --date ${yyyymmdd} --work_dir ${DATAinput} -v "v2022-07"
This is against the NCO implementation standards
Please move those python scripts from ~/sorc to ~/ush and then allow ex-scripts to call those python scripts from ~/ush
It seems there are a lot of scripts run from the sorc/ directory. Please correct all of them.
Thanks ! @bbakernoaa @chan-hoo
The text was updated successfully, but these errors were encountered: