-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle on/off workflow tasks #645
Merged
gsketefian
merged 10 commits into
ufs-community:develop
from
gsketefian:feature/deactivate_tasks
Dec 6, 2021
Merged
Toggle on/off workflow tasks #645
gsketefian
merged 10 commits into
ufs-community:develop
from
gsketefian:feature/deactivate_tasks
Dec 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e new experiment variable DEBUG is set to TRUE (as opposed to VERBOSE being set to TRUE).
…nt variable DEBUG is set to TRUE (as opposed to VERBOSE being set to TRUE). Also, for brevity, rename variable file_full_path to file_fp.
…stead of VERBOSE to reduce clutter in output.
…d/or config.sh, i.e. variables whose definitions contain other variables, e.g. MY_CMD="ls \${SOME_DIR}".
…of workflow tasks that don't already have this capability.
…orkflow that don't yet have this capability.
…o workflow XML) various tasks.
gsketefian
requested review from
BenjaminBlake-NOAA,
JeffBeck-NOAA and
mkavulich
as code owners
December 6, 2021 19:12
JeffBeck-NOAA
approved these changes
Dec 6, 2021
JeffBeck-NOAA
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Add capability to turn on/off those workflow tasks that currently do not have this capability. These tasks are:
a. Getting the external model files for creating initial conditions (
GET_EXTRN_ICS_TN
).b. Getting the external model files for creating boundary conditions (
GET_EXTRN_LBCS_TN
).c. Regridding/interpolating data from the external model IC files to obtain IC fields on the native grid (
MAKE_ICS_TN
).d. Regridding/interpolating data from the external model LBC files to obtain LBC fields on the native grid (
MAKE_LBCS_TN
).e. Running the forecast (
RUN_FCST
).Note that any remaining tasks in the workflow already have the capability to be toggled on/off.
Add a WE2E test (named
deactivate_tasks
) to test the ability to turn off tasks. In this test, all the tasks exceptMAKE_GRID_TN
,MAKE_OROG_TN
, andMAKE_SFC_CLIMO_TN
are turned off (the latter 3 are not turned off because there is already a separate WE2E for turning those three off).TESTS CONDUCTED:
Ran the new WE2E test (
deactivate_tasks
) successfully on Hera.DOCUMENTATION:
Necessary documentation has been included in
config_defaults.sh
. Created Issue #646 to also update rst documentation.