Merge pull request #34 from udacity/claudio/feat/FIN-459_PIE-1157_Doc…

…ker_USER_directive

FIN-459 - PIE-1157 - Implement Docker Container Best Practices

Dockerfile

@@ -11,5 +11,9 @@ RUN bundle config --local set without 'development test' \
     && bundle config --local deployment true \
     && bundle install --jobs 20 --retry 5
 
+RUN adduser --disabled-password -u 1001 appuser \
+   && chown -R appuser:appuser /app
+
+USER appuser:appuser
 ENV RACK_ENV production
 CMD ["bundle", "exec", "ruby", "fomotograph.rb", "-p", "4567"]

Makefile

@@ -11,7 +11,13 @@ export
 all: build
 
 test:
-	@echo "Nothing to test..."
+	docker-compose up -d --build && sleep 10
+	# docker-compose exec test curl http://app:4567/healthcheck
+	docker-compose exec test curl http://app:4567/products.json -o /tmp/test1
+	docker-compose exec test jq '.' /tmp/test1
+	docker-compose exec test curl http://app:4567/erasurez -o /tmp/test2
+	docker-compose exec test jq '.' /tmp/test2
+	docker-compose down
 
 build:
 	docker build -t $(SERVICE_NAME) .

docker-compose.yml

@@ -0,0 +1,10 @@
+version: '3'
+services:
+  app:
+    build:
+      context: .
+    ports:
+      - "4567:4567"
+  test:
+    image: cimg/base:2024.01
+    command: sleep 1000