Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala cleanup #122

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Scala cleanup #122

merged 1 commit into from
Apr 18, 2018

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Apr 17, 2018

Replace deprecated Scala Stack with ArrayStack.
Remove unused imports.
Delete extraneous blank lines.

@ucbjrl
Scala cleanup
ab0fafa 
Replace deprecated Scala Stack with ArrayStack.
Remove unused imports.
Delete extraneous blank lines.
chick
chick approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; clean code is happy code

@ucbjrl ucbjrl merged commit 6630202 into master Apr 18, 2018
@ucbjrl ucbjrl deleted the scalacleanup branch April 18, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

@edwardcwang edwardcwang Awaiting requested review from edwardcwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ucbjrl @chick