-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tons more images, misc docs updates. #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. You should rebase on the latest changes to main so the CI can pass.
.github/workflows/build.yml
Outdated
image_name: [silverblue, kinoite, vauxite] | ||
major_version: [37] | ||
image_name: [silverblue, kinoite, vauxite, sericea, base] | ||
major_version: [37, 38] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gotten F38 to build, so you will have to defer F38 support to another pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah F38 appears to have a packages not found error... Didn't notice that before PR.
error: Packages not found: xorg-x11-drv-nvidia-*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-cuda*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-devel*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-kmodsrc*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-power*:525.*.fc38.x86_64
I assume the F37 errors were before you added that on-the-fly keygen for PRs. I'll try to look into those errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, F38 can just be removed from the major version matrix, as the exclude should exclude sericea from trying to build on F37.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think you should have an easier time getting the CI to pass if you rebase against the latest changes in main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still appears to be having akmods errors. Edit: Maybe not, it was just failing F38 builds tripping me out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the image can technically build, but there's a permission error from doing the push to the registry. I think I'll have to add another change to skip pushing for PRs.
The issue on F38 was the .fc38 tacked on the install argument (had to test on f38 to figure this out, thanks distrobox). |
I would remove any change for 38 from this PR. Even though F38 was branched a few days ago, it looks like it needs more time to stabilize:
|
Build step now runs 🎉... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for your work and patience on this one @EinoHR! |
I added all of the images @ https://quay.io/organization/fedora-ostree-desktops except for beta and buildroot.
Docs rebasing section also reformatted to be the same way as other code blocks.
Fedora 38 builds are added, so when it releases only docs have to be changed. F37 is still marked as "stable" and "latest", so that nobody unintentionally rebases to F38.
Also: Conventional commits!