Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tons more images, misc docs updates. #33

Merged
merged 18 commits into from
Feb 14, 2023
Merged

Add tons more images, misc docs updates. #33

merged 18 commits into from
Feb 14, 2023

Conversation

xynydev
Copy link
Member

@xynydev xynydev commented Feb 12, 2023

I added all of the images @ https://quay.io/organization/fedora-ostree-desktops except for beta and buildroot.
Docs rebasing section also reformatted to be the same way as other code blocks.
Fedora 38 builds are added, so when it releases only docs have to be changed. F37 is still marked as "stable" and "latest", so that nobody unintentionally rebases to F38.

Also: Conventional commits!

@joshua-stone joshua-stone changed the base branch from main to devel February 12, 2023 19:02
@joshua-stone joshua-stone changed the base branch from devel to main February 12, 2023 19:04
Copy link
Contributor

@joshua-stone joshua-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. You should rebase on the latest changes to main so the CI can pass.

image_name: [silverblue, kinoite, vauxite]
major_version: [37]
image_name: [silverblue, kinoite, vauxite, sericea, base]
major_version: [37, 38]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gotten F38 to build, so you will have to defer F38 support to another pull request.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah F38 appears to have a packages not found error... Didn't notice that before PR.

error: Packages not found: xorg-x11-drv-nvidia-*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-cuda*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-devel*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-kmodsrc*:525.*.fc38.x86_64, xorg-x11-drv-nvidia-power*:525.*.fc38.x86_64

I assume the F37 errors were before you added that on-the-fly keygen for PRs. I'll try to look into those errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, F38 can just be removed from the major version matrix, as the exclude should exclude sericea from trying to build on F37.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think you should have an easier time getting the CI to pass if you rebase against the latest changes in main.

Copy link
Member Author

@xynydev xynydev Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still appears to be having akmods errors. Edit: Maybe not, it was just failing F38 builds tripping me out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the image can technically build, but there's a permission error from doing the push to the registry. I think I'll have to add another change to skip pushing for PRs.

@xynydev
Copy link
Member Author

xynydev commented Feb 13, 2023

The issue on F38 was the .fc38 tacked on the install argument (had to test on f38 to figure this out, thanks distrobox).
I tried to remove it but now the filename in /tmp/akmods/nvidia/ (aka /var/cache/akmods) is something different, but I can't figure out what needs to be changed in order for it to be found. Someone more familiar with this codebase might be able to help, rn I'm just stumbling, changing some bits and hoping it works.

@joshua-stone
Copy link
Contributor

I would remove any change for 38 from this PR. Even though F38 was branched a few days ago, it looks like it needs more time to stabilize:

$ podman run -ti --entrypoint=rpm quay.io/fedora-ostree-desktops/silverblue:37 -q kernel
kernel-6.1.9-200.fc37.x86_64
$ podman run -ti --entrypoint=rpm quay.io/fedora-ostree-desktops/silverblue:38 -q kernel
kernel-6.2.0-0.rc7.20230208git0983f6bf2bfc.52.fc38.x86_64

@xynydev
Copy link
Member Author

xynydev commented Feb 14, 2023

Build step now runs 🎉...
No F38 yet but the groundwork is laid, as long as it does start working in the same way as F37.

Copy link
Contributor

@joshua-stone joshua-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joshua-stone joshua-stone merged commit aafa0fc into ublue-os:main Feb 14, 2023
@castrojo
Copy link
Member

Thanks for your work and patience on this one @EinoHR!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants