-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed builds in "Merge group checks requested" still allow a merge #191
Comments
I created a custom action to do this, and it now works well. I https://github.com/rsturla/eternal-main/blob/main/.github/actions/check-jobs-success/action.yml Where's best to PR the action to so it's hosted in ublue? |
@p5 see #197 for the simple solution I had in mind when creating this issue. I'm not sure why the job I committed the months ago was broken, I apparently was lazy in copy/paste or testing or something. I'm interested in your idea about having a shared action for doing this, but not sure where to put it off hand and wanted to knock this out in a way we have used elsewhere in the project. |
here's an example of it happening... I don't think it should occur:
#190
https://github.com/ublue-os/nvidia/actions/runs/7795059098
The text was updated successfully, but these errors were encountered: