Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed builds in "Merge group checks requested" still allow a merge #191

Closed
bsherman opened this issue Feb 6, 2024 · 2 comments · Fixed by #197
Closed

Failed builds in "Merge group checks requested" still allow a merge #191

bsherman opened this issue Feb 6, 2024 · 2 comments · Fixed by #197

Comments

@bsherman
Copy link
Contributor

bsherman commented Feb 6, 2024

here's an example of it happening... I don't think it should occur:

#190

https://github.com/ublue-os/nvidia/actions/runs/7795059098

@p5
Copy link
Member

p5 commented Feb 8, 2024

I created a custom action to do this, and it now works well. I copied took inspiration from Keycloak

https://github.com/rsturla/eternal-main/blob/main/.github/actions/check-jobs-success/action.yml

Where's best to PR the action to so it's hosted in ublue?

@bsherman
Copy link
Contributor Author

@p5 see #197 for the simple solution I had in mind when creating this issue.

I'm not sure why the job I committed the months ago was broken, I apparently was lazy in copy/paste or testing or something.

I'm interested in your idea about having a shared action for doing this, but not sure where to put it off hand and wanted to knock this out in a way we have used elsewhere in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants