This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Re-add staticcheck #266
Merged
Re-add staticcheck #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note errcheck is close to being fixed as well kisielk/errcheck#155 |
|
Whoops I meant kisielk/errcheck#159 |
Codecov Report
@@ Coverage Diff @@
## dev #266 +/- ##
==========================================
+ Coverage 71.37% 71.43% +0.06%
==========================================
Files 90 90
Lines 4527 4523 -4
==========================================
Hits 3231 3231
+ Misses 962 958 -4
Partials 334 334
Continue to review full report at Codecov.
|
konradjniemiec
approved these changes
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that dominikh/go-tools#328 is resolved, we can use staticcheck again. This updates the version of staticcheck that is downloaded, and re-adds it to the lint target. unused has been merged into staticcheck and is deprecated. This also fixes three issues that got introduced that staticcheck now returns.