Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 764 to handle edge case in one hot encoding transformation #766

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

paullo0106
Copy link
Collaborator

@paullo0106 paullo0106 commented Apr 24, 2024

Proposed changes

This PR fixes #764 by assigning X_new to the first non-null transformed column X_col rather than only the first column.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@paullo0106
Copy link
Collaborator Author

@jeongyoonlee I feel logically speaking, this PR makes sense to improve the code (which comes from Kaggler repo and we can modify things there too if needed).

However, I'm curious about which dataset was used by craftsliu that x.fillna(NAN_INT).map(self.label_encoders[i]).fillna(0) in _transform_col() would return a null value and then therefore throw an error in transform() function

@paullo0106 paullo0106 merged commit cc30c4a into master Apr 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneHotEncoder UnboundLocalError
2 participants