Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sensitivity tests with more meta-learners #759

Merged
merged 6 commits into from
Apr 13, 2024

Conversation

jeongyoonlee
Copy link
Collaborator

@jeongyoonlee jeongyoonlee commented Apr 12, 2024

Proposed changes

This PR adds S/T/R learners to test_Sensitivity(), in addition to X-learner.
It also fixes lint errors and removes legacy Python2 syntax, such as __future__ and class X(object):.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This PR depends on #758, which fixes #757. Until #758 is merged, tests will fail.

Copy link
Collaborator

@t-tte t-tte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit 2ce28c1 into master Apr 13, 2024
16 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/update_sensitivity_tests branch April 13, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return_ci=True is not properly passed in get_ate_ci of the Sensitivity class in sensitivity.py
2 participants