Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually specify multiprocessing use fork in setup.py #754

Merged

Conversation

IanDelbridge
Copy link
Contributor

@IanDelbridge IanDelbridge commented Apr 3, 2024

Proposed changes

This fixes a bug (cython/cython#3262) related to compiling Cython with nthreads>0 in python >=3.8 on MacOS.

Alternatives:

  • always setting nthreads to 0
  • explicitly checking for MacOS and python>=3.8

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@IanDelbridge IanDelbridge marked this pull request as ready for review April 5, 2024 13:03
@jeongyoonlee
Copy link
Collaborator

I can't reproduce the issue with master, Cython=0.29.34, Python3.8, and macOS (M1, Sonoma). What environment are you using?

@IanDelbridge
Copy link
Contributor Author

IanDelbridge commented Apr 16, 2024

Oh interesting. I apologize - I should have included more about my environment. I am using

  • Cython 0.29.34
  • python 3.8.17
  • causalml 0.15.1.dev0 built from master, see below
  • macOS Sonoma Version 14.3 (M2 Max)

I built this environment with the following steps:

pyenv virtualenv 3.8.17 fresh-causalml-developer-py38
pyenv shell fresh-causalml-developer-py38
cd causalml/
git checkout master
git pull origin
pip install ".[test]"
make build // results in the cython issue linked above. 

@jeongyoonlee
Copy link
Collaborator

Thanks @IanDelbridge. I was able to reproduce both the issue and the resolution.

@jeongyoonlee jeongyoonlee self-requested a review April 18, 2024 18:09
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee merged commit c48804d into uber:master Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants