Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_std, with_counts to create_table_one #748

Merged

Conversation

lee-junseok
Copy link
Contributor

@lee-junseok lee-junseok commented Mar 22, 2024

Proposed changes

A auxiliary function create_table_one currently generates a table of mean values in a string format of "{:.2f} ({:.2f})".format(x.mean(), x.std()) and a user cannot use the mean values directly from the output table along with SMD calculated.

Issue: #747

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@jeongyoonlee
Copy link
Collaborator

Thanks for your contribution, @lee-junseok. Currently, the linting test is failing. Can you run the latest black and update the PR? Thanks.

@paullo0106
Copy link
Collaborator

@lee-junseok you can find the details in the failed log here. To fix the formatting error with black, you can check our contribution guide. Thanks

# move to the top directory of the causalml repository
$ cd causalml 
$ pip install -U black
$ black . 

@lee-junseok lee-junseok marked this pull request as ready for review April 12, 2024 15:59
@lee-junseok
Copy link
Contributor Author

lee-junseok commented Apr 12, 2024

Sorry for the delay. Addressed the issue and made it ready for review. Thank you!

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee merged commit 18c323d into uber:master Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants