Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for causal trees missing values support #733 #734

Merged

Conversation

alexander-pv
Copy link
Collaborator

Proposed changes

This PR contains a temporary stub aimed at fixing current causal trees issue #733 with new scikit-learn versions.

Related sklearn PRs:

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@alexander-pv alexander-pv changed the title Temporary fix for #733 Temporary fix for causal trees missing values support #733 Jan 26, 2024
@jeongyoonlee jeongyoonlee added the bug Something isn't working label Jan 26, 2024
@jeongyoonlee
Copy link
Collaborator

Thanks for the quick fix, @alexander-pv. Can you fix the lint check failure by running the latest black?

@alexander-pv
Copy link
Collaborator Author

Thanks for the quick fix, @alexander-pv. Can you fix the lint check failure by running the latest black?

Done

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit 9e1f892 into uber:master Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants