Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose n_jobs for rlearner #714

Merged
merged 1 commit into from
Dec 1, 2023
Merged

expose n_jobs for rlearner #714

merged 1 commit into from
Dec 1, 2023

Conversation

ZiJiaW
Copy link
Contributor

@ZiJiaW ZiJiaW commented Nov 21, 2023

Proposed changes

The Rlearner interface uses cross_val_predict to predict mu but did not expose n_jobs params. The default value of n_jobs uses all processors, which may consumes too much memory (to OOM) especially for large dataset. The cross_val_predict method uses joblib for parallelization, the memory will grow with the number of workers. It's more reasonable to expose this param and let users decide.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Nope

@jeongyoonlee jeongyoonlee self-requested a review December 1, 2023 17:51
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@jeongyoonlee jeongyoonlee added the enhancement New feature or request label Dec 1, 2023
@jeongyoonlee jeongyoonlee merged commit bae55f5 into uber:master Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants