Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the numpy and pandas version restriction in pyproject.toml #681

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

jeongyoonlee
Copy link
Collaborator

@jeongyoonlee jeongyoonlee commented Sep 22, 2023

Proposed changes

This PR fixes #680 by removing the numpy and pandas version restriction in pyproject.toml. I tested causalml with the latest numpy and pandas locally and it passed the build and all tests.

I also removed ntree_limit from GradientBoostedPropensityModel.predict() to reflect the latest XGBoost API updates and resolve the build error (e.g., https://github.com/uber/causalml/actions/runs/6285485709/job/17079160049?pr=683).

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@jeongyoonlee jeongyoonlee merged commit 0a81e49 into master Oct 3, 2023
10 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/update_numpy_pandas_versions branch October 3, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support numpy 1.24.3
2 participants