Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ras44/651 graph viz, resolves #651 #661

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

ras44
Copy link
Collaborator

@ras44 ras44 commented Aug 22, 2023

Proposed changes

#651 is a bug that arises when displaying uplift trees using GraphViz. This PR resolves that bug by adding:

  • updates to README.md
  • a test of the GraphViz visualization
  • updates to github build-from-source workflow

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@vincewu51 vincewu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vincewu51 vincewu51 merged commit 41aa6bd into uber:master Aug 22, 2023
2 of 6 checks passed
@ras44 ras44 mentioned this pull request Aug 23, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvocationException: GraphViz's executables not found in examples/uplift_tree_visualization.ipynb
3 participants