Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 252 #660

Merged
merged 2 commits into from
Aug 19, 2023
Merged

issue 252 #660

merged 2 commits into from
Aug 19, 2023

Conversation

vincewu51
Copy link
Collaborator

Proposed changes

Fix issue by pass figsize into the function

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@paullo0106 paullo0106 self-requested a review August 19, 2023 01:48
Copy link
Collaborator

@paullo0106 paullo0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @vincewu51 maybe you can also enhance the documentation by adding the missing Args: section to this function altogether?

@vincewu51
Copy link
Collaborator Author

LGTM - @vincewu51 maybe you can also enhance the documentation by adding the missing Args: section to this function altogether?

Added Args, please review again. Thanks.

@vincewu51 vincewu51 merged commit c0e3ec5 into master Aug 19, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to adjust figsize when plotting feature importance
2 participants