Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 650 #659

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Fix issue 650 #659

merged 4 commits into from
Aug 25, 2023

Conversation

vincewu51
Copy link
Collaborator

@vincewu51 vincewu51 commented Aug 19, 2023

Proposed changes

Fix issue by add back the version in init.py

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@vincewu51 vincewu51 changed the title Fix issue 654 Fix issue 650 Aug 19, 2023
@jeongyoonlee
Copy link
Collaborator

As I left a comment in #650, let's update the notebooks to use importlib.metadata.version('causalml') instead of causalml.__version__.

@jeongyoonlee jeongyoonlee self-requested a review August 24, 2023 21:57
@vincewu51
Copy link
Collaborator Author

Sounds good. Fixed few other notebook too.

ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 25, 2023
@ras44
Copy link
Collaborator

ras44 commented Aug 25, 2023

@vincewu51 I duplicated some work here, please ignore the commits linked to above in ras44/causalml that reference this issue

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee self-requested a review August 25, 2023 17:06
@jeongyoonlee jeongyoonlee merged commit 0bf110f into master Aug 25, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when benchmark_simulation_studies.ipynb calls print(causalml.__version__)
3 participants