Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simulate_randomized_trial #656

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

bsaunders23
Copy link
Contributor

Proposed changes

Caught a bug in the simulation of randomized trial data, prior code of np.maximum(np.repeat(0.0, n), X[:, 0] + X[:, 1], X[:, 2]) was actually returning np.maximum(np.repeat(0.0,n), X[:,0] + X[:,1]) and assigning the value of this to X[:,2] based on the documentation (see out).

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Impact of this is issues with parameter recall on different models (X[:,2] suddenly shows up as super important under shap values when it shouldn't be related to tau). Illustration of data impact included below:

image

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@jeongyoonlee jeongyoonlee merged commit a675ad1 into uber:master Aug 18, 2023
6 checks passed
ras44 pushed a commit to ras44/causalml that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants