code cleanups #634
Merged
code cleanups #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeongyoonlee updated! |
causalml/inference/meta/tmle.py
Outdated
| @@ -126,7 +126,7 @@ def __repr__(self): | |||
| self.__class__.__name__, self.model_tau.__repr__(), self.cv | |||
| ) | |||
|
|
|||
| def estimate_ate(self, X, treatment, y, p, segment=None, return_ci=False): | |||
There was a problem hiding this comment.
Ideally, it should follow the signature from causalml.inference.meta.base.BaseLearner.estimate_ate(). Can you update TMLELearner to inherit from BaseLearner and keep the function signatures consistent with other meta learners?
There was a problem hiding this comment.
Updated @jeongyoonlee and will keep this pull request simple. Will open a new one for a deeper dive into tmle.py
Keeping this pull request simple.
ras44
pushed a commit
to ras44/causalml
that referenced
this pull request
Aug 22, 2023
* code cleanups * lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Small code cleanups.
Types of changes
What types of changes does your code introduce to CausalML?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.