Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on **kwargs in plot_shap_values of base meta leaner #627

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

kklein
Copy link
Contributor

@kklein kklein commented Jun 28, 2023

Proposed changes

As of now, the plot_shap_values method of the base meta learner class has a **kwargs parameter. Yet, the latter isn't actually passed to the plot_shap_values method of the explainer. The latter would pass those to actual plotting methods, allowing e.g. for setting show=False.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This is analogous to #603.

@kklein
Copy link
Contributor Author

kklein commented Jul 7, 2023

Hi @jeongyoonlee, is there something I would need to provide to make this PR move forward?

@jeongyoonlee
Copy link
Collaborator

Builds are failing due to the change in the latest numpy and pandas. I submitted #631 to fix it. Once we confirm all builds pass, we can approve and merge this PR.

@jeongyoonlee jeongyoonlee self-requested a review July 7, 2023 21:49
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit b395fa3 into uber:master Jul 8, 2023
3 of 6 checks passed
jeongyoonlee pushed a commit that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants