-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug of incorrent result in qini for multiple models #520
Conversation
enzoliao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Hi @enzoliao thanks for submitting the PR! LGTM, wondering do you think if you can add the test code for this or we could open an issue to address it separately as well? T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for catching this.
Hi @ppstacy . Thank you for your reviewing and it's okay for me to add some testing code. I'm wondering where should I put test code. Is it okay to add a new |
Just add a simple test here. It will make sure that |
Hi @enzoliao thanks for preparing the test code. Yeah we can merge this one first. |
Proposed changes
Similar to #273 , the
get_qini
function re-uses the samedf
during evaluation for multiple models.Therefore, result of the second model could be influenced by the first model.
This PR will fix the issue #519 by copying a new
sorted_df
in evaluation for each model.Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.