Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filter F doesn't work with latest statsmodels' F test fvalue format #505

Merged
merged 2 commits into from
May 1, 2022

Conversation

paullo0106
Copy link
Collaborator

Proposed changes

This PR fixes #503.

In previous versions of statsmodels, f_test() of OLS model had fvalue in 2D (1x1) numpy array format, but it now becomes a single float value in the recent versions (please see the change description and the respective PR on statsmodels repo).

Similar to the diff in statsmodels repo, by applying float() to F_test.fvalue, we can safely convert the returned value to a single float number for both scenarios in our feature selection F filter, regardless of the version of statsmodels.

>>> fvalue = array([[194.9527]])
>>> fvalue.shape
(1, 1)
>>> float(fvalue)
194.9527

In addition, added test cases for Feature selection functions

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@paullo0106
Copy link
Collaborator Author

paullo0106 commented Apr 30, 2022

note: I use black to reformat optimize/__init__.py and optimize/pns.py along with my tests/test_feature_selection.py to pass Lint, for the most part, the previous failures was due to the use of single quote rather than double quotes

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee merged commit 87950fb into master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F method for variable selection returns TypeError
2 participants