Fix Filter F doesn't work with latest statsmodels' F test fvalue format #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes #503.
In previous versions of
statsmodels
,f_test()
of OLS model hadfvalue
in 2D (1x1) numpy array format, but it now becomes a single float value in the recent versions (please see the change description and the respective PR on statsmodels repo).Similar to the diff in statsmodels repo, by applying
float()
toF_test.fvalue
, we can safely convert the returned value to a single float number for both scenarios in our feature selection F filter, regardless of the version of statsmodels.In addition, added test cases for Feature selection functions
Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
N/A