Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the requirement version of Shap #483

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Modify the requirement version of Shap #483

merged 2 commits into from
Mar 14, 2022

Conversation

ppstacy
Copy link
Collaborator

@ppstacy ppstacy commented Mar 11, 2022

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

We had to fix the version of shap due to a release back then was breaking the system. Recently trying to add CausalML to conda, having the issue of finding the proper version of shap when build the package. Try to drop the constrain here.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • [] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2022

CLA assistant check
All committers have signed the CLA.

@ppstacy
Copy link
Collaborator Author

ppstacy commented Mar 14, 2022

All checks have passed, so will merge it.

@ppstacy ppstacy closed this Mar 14, 2022
@ppstacy ppstacy reopened this Mar 14, 2022
@ppstacy ppstacy merged commit e5089f8 into master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants