Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code using black #474

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Reformat code using black #474

merged 4 commits into from
Feb 14, 2022

Conversation

jeongyoonlee
Copy link
Collaborator

Proposed changes

This PR reformats code using black and add GitHub Action to run it for PR. It will keep the coding style and format across Python files consistent and compliant with PEP8.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@ppstacy
Copy link
Collaborator

ppstacy commented Feb 11, 2022

Thanks @jeongyoonlee! QQ what's the default line of length of black, are we able to change it?

@jeongyoonlee
Copy link
Collaborator Author

@ppstacy. It's 88 by default. It seems like we can change it in project.toml as described here.

@jeongyoonlee jeongyoonlee merged commit 7dec7fe into master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants