Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10, 3.11, 3.12 to the testing #454

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 17, 2022

https://devguide.python.org/#status-of-python-branches

Also, allow pip's new dependency resolver to work by providing multiple dependencies in the same command.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

https://devguide.python.org/#status-of-python-branches

Also, allow pip's new dependency resolver to work by providing multiple dependencies in the same command.
@ppstacy
Copy link
Collaborator

ppstacy commented Jan 18, 2022

@cclauss the build seems failed for all the versions - do you mind take a look? Thanks!

@cclauss cclauss changed the title Add Python 3.10 to the testing Add Python 3.10, 3.11, 3.12 to the testing Sep 21, 2023
@jeongyoonlee jeongyoonlee self-requested a review December 1, 2023 20:05
Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@jeongyoonlee jeongyoonlee merged commit d26e089 into uber:master Dec 1, 2023
2 checks passed
@cclauss cclauss deleted the patch-1 branch December 2, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants