Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in simulate_randomized_trial #385

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Fixed bug in simulate_randomized_trial #385

merged 1 commit into from
Sep 1, 2021

Conversation

jroessler
Copy link
Contributor

Proposed changes

Fixed bug in simulated_randomized_trial (Issue #361) . Changed b*(X) from max{Xi1 +Xi2 + Xi3,0} + max{Xi4 +Xi5,0} to
max{Xi1 +Xi2 , Xi3,0} + max{Xi4 +Xi5,0}. I also added the simulate_randomized_trial method in test_get_synthetic_preds.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@paullo0106 paullo0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@paullo0106 paullo0106 merged commit 27a55f5 into uber:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants