Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-armed Qini (maq) #662

Closed
t-tte opened this issue Aug 23, 2023 · 4 comments
Closed

Add multi-armed Qini (maq) #662

t-tte opened this issue Aug 23, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@t-tte
Copy link
Collaborator

t-tte commented Aug 23, 2023

Is your feature request related to a problem? Please describe.
Current methods for evaluating multiple costly treatments are somewhat hacky.

Describe the solution you'd like
The good folks at grf labs came up with a generalisation of the Qini curve method for multiple costly treatments.

Describe alternatives you've considered
N/A

Additional context
@erikcs is currently working to polish the Python wrapper for maq. The idea is to incorporate this in a lightweight way to Causal ML.

@t-tte t-tte added the enhancement New feature or request label Aug 23, 2023
@t-tte t-tte self-assigned this Aug 23, 2023
@ras44
Copy link
Collaborator

ras44 commented Nov 30, 2023

hi @t-tte

FYI, looks like the MAQ python package is available now: https://github.com/grf-labs/maq/tree/master/python-package

with example: https://github.com/grf-labs/maq/blob/master/python-package/notebooks/introduction.ipynb

@t-tte
Copy link
Collaborator Author

t-tte commented Dec 6, 2023

Yep, @erikcs has now now polished the Python implementation.

The idea we discussed was to implement multi-qini through CausalML.metrics.multiqini or something similar. Should be doable via a lightweight wrapper. Does this seem reasonable @erikcs, @ras44 and @jeongyoonlee?

I'm currently short on time but can look into this early next year. Alternatively, if any of you have bandwidth for an initial implementation, I'll be happy to review.

@erikcs
Copy link
Contributor

erikcs commented Dec 9, 2023

Thanks @t-tte, that sounds great! I too have a bit limited bandwidth now, but would be happy to provide input (and could also gladly hop on a zoom if anyone wants a quick live tour of how the multi-armed qini proposal works). And nice to see you @ras44, I remember you made some nice contributions to grf!

ras44 pushed a commit to ras44/causalml that referenced this issue Dec 11, 2023
ras44 pushed a commit to ras44/causalml that referenced this issue Jan 10, 2024
jeongyoonlee pushed a commit that referenced this issue Jan 12, 2024
* minimal wrapper of MAQ #662
* inherit maq docstrings
* include MAQ without wrapping #662
* update test for MAQ
* add examples/qini_curves_for_costly_treatment_arms.ipynb
* bump maq version to 0.2.2

---------

Co-authored-by: Roland Stevenson <rolandrmgservices@gmail.com>
@jeongyoonlee
Copy link
Collaborator

I'm closing this issue as we merged #729.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants