Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSpecify support on JDK 21 #869

Merged
merged 27 commits into from
Jan 10, 2024

Hacky way to collect test coverage for testJdk21 tasks

417f888
Select commit
Loading
Failed to load commit list.
Merged

Fix JSpecify support on JDK 21 #869

Hacky way to collect test coverage for testJdk21 tasks
417f888
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 1, 2023 in 0s

86.76% (-0.28%) compared to bf74867

View this Pull Request on Codecov

86.76% (-0.28%) compared to bf74867

Details

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (bf74867) 87.04% compared to head (417f888) 86.76%.
Report is 2 commits behind head on master.

❗ Current head 417f888 differs from pull request most recent head b0bf1ba. Consider uploading reports for the commit b0bf1ba to get more accurate results

Files Patch % Lines
...laway/generics/PreservedAnnotationTreeVisitor.java 65.90% 13 Missing and 2 partials ⚠️
...away/src/main/java/com/uber/nullaway/NullAway.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #869      +/-   ##
============================================
- Coverage     87.04%   86.76%   -0.28%     
- Complexity     1922     1926       +4     
============================================
  Files            77       77              
  Lines          6221     6266      +45     
  Branches       1208     1214       +6     
============================================
+ Hits           5415     5437      +22     
- Misses          404      421      +17     
- Partials        402      408       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.