Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSpecify: adding com.google.common to annotated packages in build.gradle #857

Merged

Conversation

akulk022
Copy link
Collaborator

@akulk022 akulk022 commented Nov 9, 2023

Based on the fixes made in #856 , we should no longer get that exception after adding com.google.common in the annotated packages when running in JSpecify mode.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aeb32c) 86.93% compared to head (384b7d6) 86.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #857   +/-   ##
=========================================
  Coverage     86.93%   86.93%           
  Complexity     1888     1888           
=========================================
  Files            74       74           
  Lines          6215     6215           
  Branches       1208     1208           
=========================================
  Hits           5403     5403           
  Misses          405      405           
  Partials        407      407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review November 9, 2023 23:56
@msridhar msridhar merged commit 0141aca into uber:master Nov 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants