-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Spotless for formatting Java code #780
Conversation
@@ -1,4 +1,5 @@ | |||
package com.uber.nullaway.handlers; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can fix these incorrectly-placed license headers in a follow-up
@@ -13,7 +13,6 @@ include ':sample' | |||
include ':test-java-lib' | |||
include ':test-java-lib-lombok' | |||
include ':test-library-models' | |||
include ':compile-bench' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuring Spotless made me notice this project no longer exists in the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This reverts commit 31004d3.
This reverts commit 31004d3.
This reverts commit 31004d3.
This reverts commit 31004d3.
This reverts commit 31004d3.
Our previous plugin for running Google Java Format was unmaintained. Also update our version of GJF, which leads to minor formatting changes.
In follow-ups, we can use Spotless to enforce formatting for
.gradle
files and also make license headers consistent.