Remove URI serialization for classes coming from .class files from fix serialization code. #716
Comments
msridhar
added a commit
to nimakarimipour/NullAway
that referenced
this issue
Mar 31, 2023
msridhar
pushed a commit
that referenced
this issue
Mar 31, 2023
This PR partially resolves #716 by removing URI serialization for classes coming from `.class` files in all serializations. In Annotator all serialized paths in downstream dependencies analysis phase, are neglected and retrieved from internal data structure of Annotator. Please see [Github](https://github.com/ucr-riple/NullAwayAnnotator/blob/4587c9821f4ccd152c1e6853a0cd10df5bcf277d/annotator-core/src/main/java/edu/ucr/cs/riple/core/cache/downstream/DownstreamImpactEvaluator.java#L85) I tested Annotator with a local snapshot of NullAway with latest changes in this PR and I did not see any problem. #716 is partially resolved since it requires updating path constructions in tests as well, which will be addressed in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://github.com/uber/NullAway/pull/714/files#r1070159352
We are keeping this code unchanged for peace of mind for the paper, but should removed and re-test after, since it's likely this workaround is no longer needed.
Edit: Also, let's try to have everything use
Pathsdirectly rather than operations on their string representations. See this comment.The text was updated successfully, but these errors were encountered: