Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: app_test.go: New->NewForTest #1004

Merged
merged 2 commits into from
Dec 27, 2022
Merged

chore: app_test.go: New->NewForTest #1004

merged 2 commits into from
Dec 27, 2022

Commits on Dec 27, 2022

  1. chore: app_test.go: New->NewForTest 

    The tests that cover error cases for private provides were using
New(opts...) rather than NewForTest(t, opts...) which caused the
error logs to be present in the tests when those tests run.

This changes those to use NewForTest instead.
    @sywhang
    sywhang committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    2d42d62 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into chore/privateprovidetests

    @sywhang
    sywhang authored Dec 27, 2022
    Configuration menu
    Copy the full SHA
    4d5ab92 View commit details
    Browse the repository at this point in the history