chore: app_test.go: New->NewForTest #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests that cover error cases for private provides were using New(opts...) rather than NewForTest(t, opts...) which caused the error logs to be present in the tests when those tests run. This changes those to use NewForTest instead.
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 39 39
Lines 2025 2025
=======================================
Hits 1991 1991
Misses 26 26
Partials 8 8 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tchung1118
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests that cover error cases for private provides were using New(opts...) rather than NewForTest(t, opts...) which caused the error logs to be present in the tests when those tests run.
This changes those to use NewForTest instead.