Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbars appear in click2load.html #1901

Closed
8 tasks done
ghcsd opened this issue Dec 25, 2021 · 5 comments
Closed
8 tasks done

Scrollbars appear in click2load.html #1901

ghcsd opened this issue Dec 25, 2021 · 5 comments
Labels
fixed issue has been addressed

Comments

@ghcsd
Copy link

ghcsd commented Dec 25, 2021

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

In Firefox, scrollbars always appear in click2load.html

A specific URL where the issue occurs

https://developer.mozilla.org/en-US/docs/Web/Guide/Audio_and_video_manipulation#video_and_webgl

Steps to Reproduce

  1. Add *$frame,redirect=click2load.html to My filters
  2. Open https://developer.mozilla.org/en-US/docs/Web/Guide/Audio_and_video_manipulation#video_and_webgl.

Expected behavior

Scrollbars should not appear in the placeholder document.

Actual behavior

image

uBlock Origin version

uBlock Origin 1.39.3rc1

Browser name and version

Firefox 95.0.2

Operating System and version

Windows 10

@ghcsd
Copy link
Author

ghcsd commented Dec 25, 2021

Using

body {
  width: 100vw;
  height: 100vh;
}

instead of the inline style can solve this issue.
ghcsd/uBlock@e344b64

@ghcsd ghcsd changed the title Scrollbars appear in clicktoload.html Scrollbars appear in click2load.html Dec 25, 2021
@gwarser
Copy link

gwarser commented Dec 25, 2021

image

@gwarser
Copy link

gwarser commented Dec 25, 2021

High DPI monitor? System/browser scaling?

@ghcsd
Copy link
Author

ghcsd commented Dec 25, 2021

High DPI monitor? System/browser scaling?

Yes, It is easier to reproduce when Firefox browser is not the default zoom level (eg. 110%).
You can zoom in/out (Ctrl - +/-) and refresh the page to reproduce the issue.

@uBlock-user uBlock-user added the something to address something to address label Dec 27, 2021
@ghcsd
Copy link
Author

ghcsd commented Jan 2, 2022

Adding the following CSS code to userContent.css can temporarily fix this issue.

@-moz-document regexp("moz-extension://[^/]+/web_accessible_resources/click2load\.html.+"){
  #ublock0-clicktoload > body{
    width: 100vw !important;
    height: 100vh !important;
  }
}

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 7, 2022
@uBlock-user uBlock-user added fixed issue has been addressed and removed something to address something to address labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants