Fix entering fullscreen, fixes #658 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entering fullscreen must be done _directly_ resulting from a user gesture (eg. a click). Previously the Video component would request fullscreen when it was rerendered with a different `isFullscreen` prop, which worked because the UI was rerendered synchronously when the fullscreen button was clicked. Since u-wave#629 state changes do not cause synchronous rerenders anymore, so the fullscreen request didn't occur as a direct result of the button click. This patch instead requests fullscreen immediately when the button is clicked, and only _then_ sends the ENTER_FULLSCREEN action into the app's internal state.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entering fullscreen must be done directly resulting from a user
gesture (eg. a click). Previously the Video component would request
fullscreen when it was rerendered with a different
isFullscreenprop, which worked because the UI was rerendered synchronously when
the fullscreen button was clicked.
Since #629 state changes do not cause synchronous rerenders anymore,
so the fullscreen request didn't occur as a direct result of the button
click.
This patch instead requests fullscreen immediately when the button is
clicked, and only then sends the ENTER_FULLSCREEN action into the
app's internal state.