Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove building from running time #155

Merged
merged 23 commits into from
Nov 28, 2023
Merged

Remove building from running time #155

merged 23 commits into from
Nov 28, 2023

Conversation

krzema12
Copy link
Member

@krzema12 krzema12 commented Nov 26, 2023

Part of #4.

TODO:

  • add build-time check that JARs are up-to-date

Testing

See https://github.com/typesafegithub/github-actions-typing/actions/runs/6998547009/job/19036765853

@krzema12 krzema12 changed the title Run from stored JARs Remove building from running time Nov 27, 2023
@krzema12
Copy link
Member Author

Current problem: one JAR is different. I haven't checked yet what's the difference, but it's likely the timestamps and alike. We need to compare them only content-wise, ignoring metadata. See e.g. https://unix.stackexchange.com/questions/452673/compare-two-zip-files-for-differences

@krzema12 krzema12 marked this pull request as ready for review November 28, 2023 08:18
@krzema12 krzema12 merged commit c1af344 into main Nov 28, 2023
4 checks passed
@krzema12 krzema12 deleted the store-jars-in-repo branch November 28, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant