Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The binary breaking bonanza #75

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

DavidGregory084
Copy link
Member

@DavidGregory084 DavidGregory084 commented May 6, 2022

I'm going to use this PR to batch up some breakage for 0.4

  • Most importantly - changes ScalacOptions to be private[davidgregory084] to avoid bincompat concerns with changing it in future. Interestingly if you change something to be private[somepackage] in your latest commit the MiMa warnings go away, even though your changes are still binary incompatible with the previous release.
  • Changes ScalacOption from a container of tokens: List[String] to option: String and args: List[String]. Equality is determined only by option. I think this makes more sense for users when filtering options, since when filtering an option users probably don't really care which arguments have been provided for that option.
  • Adds ScalacOptions.other. This fixes ScalacOption case class unreachable from build.sbt #65 by providing an escape hatch from the options DSL.

@armanbilge
Copy link
Member

  • Interestingly if you change something to be private[somepackage] in your latest commit the MiMa warnings go away, even though your changes are still binary incompatible with the previous release.

I'm going to lose sleep over this one 😱

@armanbilge
Copy link
Member

I've opened a PR to at least reproduce the issue in MiMa.

@DavidGregory084
Copy link
Member Author

I think these changes have waited long enough - I'm going to retrigger CI and then merge this

@DavidGregory084 DavidGregory084 merged commit 6746885 into main Jul 15, 2022
@DavidGregory084 DavidGregory084 deleted the binary-breaking-bonanza branch July 15, 2022 12:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScalacOption case class unreachable from build.sbt
2 participants