Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to use this PR to batch up some breakage for 0.4
ScalacOptions
to beprivate[davidgregory084]
to avoid bincompat concerns with changing it in future. Interestingly if you change something to beprivate[somepackage]
in your latest commit the MiMa warnings go away, even though your changes are still binary incompatible with the previous release.ScalacOption
from a container oftokens: List[String]
tooption: String
andargs: List[String]
. Equality is determined only byoption
. I think this makes more sense for users when filtering options, since when filtering an option users probably don't really care which arguments have been provided for that option.ScalacOptions.other
. This fixes ScalacOption case class unreachable from build.sbt #65 by providing an escape hatch from the options DSL.