Accept Duration for all time-based combinators
#3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… topic/more-duration
armanbilge
commented
Jul 17, 2022
Comment on lines
+290
to
298
| private[effect] def handleDuration[A](duration: Duration, ifInf: => A)( | ||
| ifFinite: FiniteDuration => A): A = | ||
| duration match { | ||
| case _: Duration.Infinite => fa | ||
| case finite: FiniteDuration => f(finite) | ||
| case fd: FiniteDuration => ifFinite(fd) | ||
| case Duration.Inf => ifInf | ||
| case d => | ||
| throw new IllegalArgumentException( | ||
| s"Duration must be either a `FiniteDuration` or `Duration.Inf`, but got: $d") | ||
| } |
There was a problem hiding this comment.
While we're here, should we also do something about negative FiniteDurations?
|
Something I'm leery about is that these changes introduce a lot of branches that aren't currently tested by our laws which I think work in terms of |
Merged
djspiewak
previously approved these changes
Sep 20, 2022
Heh, I was waiting for a positive sign before continuing :) I'm on it! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2954.