Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup codeql #145

Merged
merged 6 commits into from
Jul 15, 2023
Merged

ci: setup codeql #145

merged 6 commits into from
Jul 15, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 8, 2023

Description

CodeQL is free for open-source projects and now has beta support for Koltin so might as well run it 🤷

Checklist

  • I self reviewed the submitted code
  • I ran ./gradlew ktlintCheck detekt before submitting this PR
  • I ran the app on a device/emulator or added unit tests to verify this change

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tylerbwong
Copy link
Owner

@G-Rath Can we omit the JS scanning job? Also, it looks like we'll have to provide the specific build command.

@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 10, 2023

@tylerbwong sure, though it was added automatically since there is technically JavaScript in the repository.

I'll have a crack at getting it working with the build script, but might end up needing your help since I've not really got a lot of experience with Java/Kotlin build tools 😅

@tylerbwong tylerbwong merged commit 3956022 into tylerbwong:master Jul 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants