-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Configuration Cache Support #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Happy to try this out with a built snapshot version or a new release
val metalavaClasspath = project.getMetalavaClasspath(objectFactory, extension) | ||
val metalavaClasspath = project.getMetalavaClasspath( | ||
objectFactory, | ||
jarPath = extension.metalavaJarPath.get().ifEmpty { null }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd just pass in the propery from the extension using get() and do the .ifEmpty { null }
in the implementation to avoid duplicating the ifEmpty part
Fixes #34