Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the problem causing the import error with numpy2 #800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XotEmBotZ
Copy link

fixes #799

changed NaN to nan for numpy 2.0 support

@XotEmBotZ
Copy link
Author

The numpy is causing these errors and hindering the containers that are used. Kindly can you fast track this to main? This would at least prevent further damage.

@twopirllc
Copy link
Owner

Hello @XotEmBotZ,

I will leave this up here for those that want to manually apply to v0.3.14b. However in the original #799, the request was for a development branch fix. If you have a fix for that, development, then I have no issue applying it.

Kind Regards,
KJ

@XotEmBotZ
Copy link
Author

I have a question here,Since this is a non breaking change, can I know the reason for holding the merge? As this would allow the this version to be used with numpy2 till the development of v0.4 finishes.

@twopirllc
Copy link
Owner

@XotEmBotZ,

While it's quite likely not a breaking change, I frankly do not have the free time to address it in the event that it is. I have seen stranger things happen. 😅 It would be a different situation under different conditions.

But more importantly, thanks for providing a solution. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas-ta doesnt work with numpy 2.0
2 participants