Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace response properties with update properties #66

Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix: replace response properties with update properties #66

merged 1 commit into from
Jun 22, 2021

Conversation

childish-sambino
Copy link
Contributor

Response properties cannot be changed unless they are part of the create/update properties, so we'll only include create/update properties.

twilio/terraform-provider-twilio#40

fix: replace response properties with update properties
e829a33 
Response properties cannot be changed unless they are part of the create/update properties, so we'll only include create/update properties.
@childish-sambino childish-sambino mentioned this pull request Jun 21, 2021
Merged
shwetha-manvinkurke
shwetha-manvinkurke approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only include the update/create properties, do you know how the read operation will behave? If we do a terraform refresh, does it just ignore the properties that are not part of the resource and update the state?

@childish-sambino
Copy link
Contributor Author

@shwetha-manvinkurke Correct. The read will just ignore the properties that are not part of the schema. Things like date_created, account_sid, etc. Things you can't change directly.

@childish-sambino childish-sambino merged commit 07f8ef4 into main Jun 22, 2021
@childish-sambino childish-sambino deleted the remove-response-properties branch June 22, 2021 14:42
RJPearson94 pushed a commit to RJPearson94/twilio-oai-generator that referenced this pull request Jul 9, 2021
@RJPearson94
fix: replace response properties with update properties (twilio#66)
13e8d92
@kenske kenske mentioned this pull request Aug 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@childish-sambino @shwetha-manvinkurke