Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @type/express #675

Merged
merged 7 commits into from
May 27, 2021
Merged

fix: remove @type/express #675

merged 7 commits into from
May 27, 2021

Conversation

JenniferMah
Copy link
Contributor

Fixes

@types/express only supports TypeScript 3.5+ versions while we support TypeScript 2.9+. This PR removes all of the @types dependencies as dev dependencies except for @types/node for environment variables.

lib/webhooks/webhooks.d.ts Outdated Show resolved Hide resolved
lib/webhooks/webhooks.d.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants