Add addText method to TwiML classes #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcodes
approved these changes
Jun 14, 2018
| */ | ||
| /* jshint ignore:end */ | ||
| MessagingResponse.prototype.redirect = function redirect(attributes, url) { | ||
| this.response.ele('Redirect', attributes, url); | ||
| return new Redirect(this.response.ele('Redirect', attributes, url)); |
There was a problem hiding this comment.
Can you explain what the change from response.ele -> new Element does here? Was response.ele just the object before?
There was a problem hiding this comment.
response.ele means "add a new element with the name 'Redirect'" -- it mutated the response without returning anything.
The new code still does the mutation, but then it returns the newly-created element node (wrapped in a class named after the element).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow adding arbitrary text under TwiML nodes via the new method
addText