fix: fix unhandledRejection (#952)

* fix: unhandledRejection
twilio · Aug 10, 2023 · b7c5598 · b7c5598
1 parent 73ddddd
commit b7c5598
Showing 1 changed file with 27 additions and 26 deletions.
diff --git a/src/base/Version.ts b/src/base/Version.ts
@@ -311,32 +311,33 @@ export default class Version {
         return;
       }
 
-      promise.then((page: any) => {
-        try {
-          page.instances.forEach(function (instance: any) {
-            if (
-              done ||
-              (typeof params.limit !== "undefined" &&
-                currentResource >= params.limit)
-            ) {
-              done = true;
-              return false;
-            }
-            currentResource++;
-            callback?.(instance, onComplete);
-          });
-        } catch (e) {
-          return onComplete(e);
-        }
-
-        if (!done) {
-          currentPage++;
-          fetchNextPage(page.nextPage.bind(page));
-        } else {
-          onComplete();
-        }
-      });
-      promise.catch(onComplete);
+      promise
+        .then((page: any) => {
+          try {
+            page.instances.forEach(function (instance: any) {
+              if (
+                done ||
+                (typeof params.limit !== "undefined" &&
+                  currentResource >= params.limit)
+              ) {
+                done = true;
+                return false;
+              }
+              currentResource++;
+              callback?.(instance, onComplete);
+            });
+          } catch (e) {
+            return onComplete(e);
+          }
+
+          if (!done) {
+            currentPage++;
+            fetchNextPage(page.nextPage.bind(page));
+          } else {
+            onComplete();
+          }
+        })
+        .catch(onComplete);
     }
 
     return new Promise((resolve, reject) => {